fix(helm): use correct templating for mcpClientConfig by crust3780 · Pull Request #2673 · maximhq/bifrost

crust3780 · 2026-04-13T09:07:16Z

Summary

Fix MCP client values not being rendered into config.json in the Helm ConfigMap due to key-name mismatch.

Changes

Updated MCP client templating to read camelCase Helm values and emit snake_case config keys:
- toolsToExecute → tools_to_execute
- toolsToAutoExecute → tools_to_auto_execute
- authType → auth_type
- oauthConfigId → oauth_config_id

Type of change

Affected areas

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Render Helm chart with MCP client values
cat >/tmp/mcp-values.yaml <<'EOF'
bifrost:
  mcp:
    enabled: true
    clientConfigs:
      - name: mcp-http
        connectionType: http
        httpConfig:
          url: https://example-http
        authType: oauth
        oauthConfigId: oauth-1
        toolsToExecute: ["a", "b"]
        toolsToAutoExecute: ["a"]
EOF

helm template test ./helm-charts/bifrost -f  | grep -E 'tools_to_execute|tools_to_auto_execute|auth_type|oauth_config_id'

CLAassistant · 2026-04-13T09:07:25Z

All committers have signed the CLA.

coderabbitai · 2026-04-13T09:09:52Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc453437-36f5-41c3-b848-66e3af96fe18

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc568d and b5113d3.

📒 Files selected for processing (4)

helm-charts/bifrost/Chart.yaml
helm-charts/bifrost/README.md
helm-charts/bifrost/templates/_helpers.tpl
helm-charts/index.yaml

📝 Walkthrough

Summary by CodeRabbit

Bug Fixes
- Fixed MCP client configuration mapping to correctly convert camelCase Helm values to the expected snake_case format.
Chores
- Bumped Helm chart version to 2.0.18.

Walkthrough

This pull request releases Helm chart version 2.0.18 for bifrost, updating the chart version, documentation, and template configuration. The MCP client configuration template was modified to accept camelCase property names while maintaining snake_case output keys.

Changes

Cohort / File(s)	Summary
Chart Release Metadata `helm-charts/bifrost/Chart.yaml`, `helm-charts/index.yaml`	Incremented chart version from 2.0.17 to 2.0.18 and added corresponding entry to Helm index with appVersion 1.4.11 and artifact metadata.
Documentation `helm-charts/bifrost/README.md`	Updated "Latest Version" reference to 2.0.18 and added changelog entry documenting the MCP client config template fix for camelCase-to-snake_case key mapping.
Template Configuration `helm-charts/bifrost/templates/_helpers.tpl`	Modified MCP client config template to accept Helm values with camelCase keys (`toolsToExecute`, `toolsToAutoExecute`, `authType`, `oauthConfigId`) while outputting snake_case config fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A version hops along the chart so fine,
CamelCase now dances in the Helm design,
From snake to camel, the keys align,
Two-point-eighteen makes the config shine! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-04-13T09:16:42Z

Confidence Score: 5/5

Safe to merge — the template fix is correct and well-scoped; only a minor README documentation gap remains.

The core change is a targeted, correct fix verified against values.schema.json. The only finding is a missing v2.0.17 changelog entry in the README, which is a P2 documentation concern and does not affect runtime behavior.

helm-charts/bifrost/README.md — missing v2.0.17 changelog entry

Important Files Changed

Filename	Overview
helm-charts/bifrost/templates/_helpers.tpl	Corrects four camelCase key lookups that were silently reading undefined snake_case keys; output keys remain snake_case. Fix aligns with values.schema.json definitions.
helm-charts/bifrost/Chart.yaml	Bumps chart version from 2.0.17 to 2.0.18 to accompany the template bug fix.
helm-charts/bifrost/README.md	Adds v2.0.18 changelog entry, but the v2.0.17 entry is absent — the changelog jumps directly from v2.0.18 to v2.0.16.
helm-charts/index.yaml	New v2.0.18 index entry added; empty digest is consistent with the existing pattern for all other versions in this file.

_{Reviews (1): Last reviewed commit: "fix(helm): use correct templating for mc..." | Re-trigger Greptile}

greptile-apps · 2026-04-13T09:16:46Z

+  - `authType` → `auth_type`
+  - `oauthConfigId` → `oauth_config_id`
+
 ### v2.0.16


Missing v2.0.17 changelog entry

The changelog jumps from v2.0.18 directly to v2.0.16, skipping v2.0.17. Since Chart.yaml was previously at 2.0.17, users upgrading from that version will have no entry describing what changed there.

Suggested change

### v2.0.16

### v2.0.17

- (add changelog entry for 2.0.17 here)

### v2.0.16

fix(helm): use correct templating for mcpClientConfig (maximhq#2673)

crust3780 force-pushed the push-tkztvwqwomlt branch from 0947b18 to 3bc8bd5 Compare April 13, 2026 09:09

fix(helm): use correct templating for mcpClientConfig

b5113d3

crust3780 force-pushed the push-tkztvwqwomlt branch from 3bc8bd5 to b5113d3 Compare April 13, 2026 09:13

crust3780 marked this pull request as ready for review April 13, 2026 09:14

crust3780 requested a review from a team as a code owner April 13, 2026 09:14

akshaydeo approved these changes Apr 13, 2026

View reviewed changes

akshaydeo merged commit a8cf690 into maximhq:main Apr 13, 2026
2 of 4 checks passed

greptile-apps Bot reviewed Apr 13, 2026

View reviewed changes

dominictayloruk added a commit to dominictayloruk/bifrost that referenced this pull request Apr 13, 2026

Merge pull request #7 from maximhq/main

898e16c

fix(helm): use correct templating for mcpClientConfig (maximhq#2673)

dominictayloruk added a commit to dominictayloruk/bifrost that referenced this pull request Apr 13, 2026

Merge pull request #8 from maximhq/main

9d84dc7

fix(helm): use correct templating for mcpClientConfig (maximhq#2673)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(helm): use correct templating for mcpClientConfig#2673

fix(helm): use correct templating for mcpClientConfig#2673
akshaydeo merged 1 commit intomaximhq:mainfrom
crust3780:push-tkztvwqwomlt

crust3780 commented Apr 13, 2026

Uh oh!

CLAassistant commented Apr 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 13, 2026

Uh oh!

greptile-apps Bot Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

crust3780 commented Apr 13, 2026

Summary

Changes

Type of change

Affected areas

How to test

Uh oh!

CLAassistant commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 13, 2026

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CLAassistant commented Apr 13, 2026 •

edited

Loading

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading